Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java 21 #434

Closed
wants to merge 11 commits into from
Closed

Java 21 #434

wants to merge 11 commits into from

Conversation

edeandrea
Copy link
Collaborator

Convert to Java 21 baseline

Fixes #376

Signed-off-by: Eric Deandrea <[email protected]>

# Conflicts:
#	.github/workflows/build-push-container-images.yml
#	.github/workflows/simple-build-test.yml
#	event-statistics/pom.xml
#	grpc-locations/pom.xml
#	rest-fights/pom.xml
#	rest-heroes/pom.xml
#	rest-narration/README.md
#	rest-narration/pom.xml
#	rest-villains/pom.xml
#	scripts/generate-k8s-resources.sh
#	ui-super-heroes/pom.xml

# Conflicts:
#	event-statistics/src/main/docker/Dockerfile.jvm
#	event-statistics/src/main/docker/Dockerfile.legacy-jar
#	event-statistics/src/main/resources/application.properties
#	grpc-locations/src/main/docker/Dockerfile.jvm
#	grpc-locations/src/main/docker/Dockerfile.legacy-jar
#	grpc-locations/src/main/resources/application.yml
#	rest-fights/src/main/docker/Dockerfile.jvm
#	rest-fights/src/main/docker/Dockerfile.legacy-jar
#	rest-fights/src/main/resources/application.properties
#	rest-heroes/src/main/docker/Dockerfile.jvm
#	rest-heroes/src/main/docker/Dockerfile.legacy-jar
#	rest-heroes/src/main/resources/application.yml
#	rest-narration/src/main/docker/Dockerfile.jvm
#	rest-narration/src/main/docker/Dockerfile.legacy-jar
#	rest-narration/src/main/resources/application.properties
#	rest-villains/src/main/docker/Dockerfile.jvm
#	rest-villains/src/main/docker/Dockerfile.legacy-jar
#	rest-villains/src/main/resources/application.properties
#	ui-super-heroes/src/main/docker/Dockerfile.jvm
#	ui-super-heroes/src/main/docker/Dockerfile.legacy-jar
#	ui-super-heroes/src/main/resources/application.properties
Signed-off-by: Eric Deandrea <[email protected]>

# Conflicts:
#	.github/workflows/simple-build-test.yml

# Conflicts:
#	.github/workflows/simple-build-test.yml
Signed-off-by: Eric Deandrea <[email protected]>
Signed-off-by: Eric Deandrea <[email protected]>
Signed-off-by: Eric Deandrea <[email protected]>
Signed-off-by: Eric Deandrea <[email protected]>
Signed-off-by: Eric Deandrea <[email protected]>
@gastaldi
Copy link

gastaldi commented Sep 4, 2024

Looks like this PR is ready to go? What's missing?

@edeandrea
Copy link
Collaborator Author

We were holding off on making the switch to java 21 as a baseline. We did this PR shortly after java 21 came out, so it was thought it may be better to wait a bit.

That being said, I'm totally open to revisiting it. This PR would need some updates since main has diverged a bit from this PR branch. But it's close.

@edeandrea
Copy link
Collaborator Author

@gastaldi I'm thinking that I will revisit this after RHBQ 3.15 ships. That way we have an rhbq-3.15 LTS branch with a Java 17 baseline and future versions can baseline on Java 21.

@cescoffier / @geoand what do you think?

@geoand
Copy link
Collaborator

geoand commented Oct 14, 2024

No strong opinions either way

@edeandrea
Copy link
Collaborator Author

@gastaldi I'm thinking that I will revisit this after RHBQ 3.15 ships. That way we have an rhbq-3.15 LTS branch with a Java 17 baseline and future versions can baseline on Java 21.

Actually now that we have a 3.15.Final branch with a Java 17 baseline I think I will move main to Java 21. When RHBQ 3.15 comes out it will be branched from the 3.15.Final branch.

@edeandrea
Copy link
Collaborator Author

Since main has diverged so much since this PR was originally drafted, I'm going to close this in favor of #1234

@edeandrea edeandrea closed this Oct 21, 2024
@edeandrea edeandrea deleted the java-21-only branch October 22, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce Java 21
4 participants